fix: Disable clear button instead of removing it#1203
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the clear button behavior in the Select component to be disabled instead of removed when the select itself is disabled, improving UX consistency.
Changes:
- Modified SearchBar component to render clear button even when disabled, passing the disabled prop to the button
- Added disabled state styling to ClearButton to show appropriate visual feedback
- Updated test expectations to verify the clear button is disabled rather than not rendered
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/molecules/Select/SearchBar.tsx | Removed disabled condition from clear button rendering logic and added disabled prop to ClearButton |
| src/molecules/Select/Select.styles.ts | Added disabled state styling for clear button with appropriate fill color |
| src/molecules/Select/SingleSelect/SingleSelect.stories.tsx | Updated test to verify clear button is disabled instead of checking it's not rendered |
| src/molecules/Select/Select.types.ts | Formatting changes to interface declarations (no functional changes) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aslakihle
approved these changes
Jan 12, 2026
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure DevOps links
User story
Description